Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] TkAl: fix PV validation and PV resolution submission scripts #44468

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 19, 2024

backport of #44467

PR description:

The goal of this PR is to fix the scripts submitPVResolutionJobs.py and submitPVValidationJobs.py such that they can run in recent releases and with recent (Run 3) data.
The related unit tests are improved such that, in addition to technically creating the configuration to be run with HTCondor, said configuration is also tested for at least one job (running locally).

PR validation:

Run successfully:

  • scram b runtests_SubmitPVsplit
  • scram b runtests_SubmitPVrbr

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #44467 for the 2024 data-taking release

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@yuanchao, @adewit, @rsreds, @tlampen, @mmusich, @tocheng this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2024

cms-bot internal usage

@mmusich mmusich force-pushed the mm_submitPVValidationJobs_updates_14_0_X branch from a9842ff to 98cbc90 Compare March 19, 2024 21:08
@cmsbuild
Copy link
Contributor

Pull request #44468 was updated. @saumyaphor4252, @cmsbuild, @consuegs, @perrotta can you please check and sign again.

@mmusich mmusich force-pushed the mm_submitPVValidationJobs_updates_14_0_X branch from 98cbc90 to 824278a Compare March 20, 2024 08:51
@cmsbuild
Copy link
Contributor

Pull request #44468 was updated. @cmsbuild, @consuegs, @saumyaphor4252, @perrotta can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 20, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49b002/38275/summary.html
COMMIT: 824278a
CMSSW: CMSSW_14_0_X_2024-03-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44468/38275/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 98 lines to the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346212
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346190
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Mar 21, 2024

type bug-fix

@perrotta
Copy link
Contributor

@mmusich I am noticing that L193 of Alignment/OfflineValidation/scripts/submitPVResolutionJobs.py was commented out in the master version of this PR, but not in this backport. Was it done on purpose?

@mmusich
Copy link
Contributor Author

mmusich commented Mar 21, 2024

. Was it done on purpose?

no, even if it's harmless, it should be commented (or even removed) also here, because that script is not accessible when executing unit tests:

./batchHarvester_Prompt_0.sh: line 2: /afs/cern.ch/cms/caf/setup.sh: No such file or directory

at the end of the log file

@mmusich mmusich force-pushed the mm_submitPVValidationJobs_updates_14_0_X branch from 824278a to e476972 Compare March 21, 2024 10:00
@cmsbuild
Copy link
Contributor

Pull request #44468 was updated. @perrotta, @consuegs, @cmsbuild, @saumyaphor4252 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 21, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49b002/38321/summary.html
COMMIT: e476972
CMSSW: CMSSW_14_0_X_2024-03-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44468/38321/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d44f56c into cms-sw:CMSSW_14_0_X Mar 21, 2024
10 checks passed
@mmusich mmusich deleted the mm_submitPVValidationJobs_updates_14_0_X branch March 21, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants